Ofer Schreiber has posted comments on this change.
Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1035: basedefs.EXEC_PSQL,
Line 1036: "--version",
Line 1037: ]
Line 1038: out, rc = execCmd(cmdList=cmd, failOnError=True,
msg=output_messages.ERR_PSQL)
Line 1039: if "9.2" in out:
Any reason to rely on output instead of rpm/miniyum python api?
Line 1040: logging.info("Detected PostgreSQL version 9.2")
Line 1041: pid = "pid"
Line 1042:
Line 1043: logging.info("Disconnect active connections from DB '%s'" %
dbName)
--
To view, visit http://gerrit.ovirt.org/10389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
