Gilad Chaplik has posted comments on this change. Change subject: core: Fast update quota cache ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/dbscripts/quota_sp.sql Line 73: BEGIN Line 74: RETURN QUERY SELECT cast(count(*) as INTEGER) as num_quota Line 75: FROM quota; Line 76: END; $procedure$ Line 77: LANGUAGE plpgsql; As I mentioned in earlier comments, this number is managed by server side. sorry for not mentioning why I object to this SP, the reason is performance BTW, IMHO if we can save a call to DB, we must do it. Line 78: Line 79: Create or replace FUNCTION GetQuotaStorageByQuotaGuid(v_id UUID) Line 80: RETURNS SETOF quota_storage_view Line 81: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/10159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
