Yair Zaslavsky has posted comments on this change.

Change subject: core: Fast init cache
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java
Line 185: 
Line 186:     @Override
Line 187:     public int getQuotaCount() {
Line 188:         MapSqlParameterSource parameterSource = new 
MapSqlParameterSource();
Line 189:         return getCallsHandler().executeRead("GetQuotaCount", new 
ParameterizedRowMapper<Integer>() {
Please perform the new only once using a static field.
Line 190:             @Override
Line 191:             public Integer mapRow(ResultSet resultSet, int i) throws 
SQLException {
Line 192:                 return (Integer) resultSet.getObject(1);
Line 193:             }


--
To view, visit http://gerrit.ovirt.org/10159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to