Doron Fediuck has posted comments on this change.
Change subject: core: Fast update quota cache
......................................................................
Patch Set 9: (2 inline comments)
See inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 55: protected QuotaDAO getQuotaDAO() {
Line 56: return DbFacade.getInstance().getQuotaDao();
Line 57: }
Line 58:
Line 59: public synchronized void removeQuotaFromCache(Guid storagePoolId,
List<Guid> quotaList) {
Please check if really needed.
Line 60: lock.writeLock().lock();
Line 61: try {
Line 62: if (!storagePoolQuotaMap.containsKey(storagePoolId)) {
Line 63: return;
Line 991: } finally {
Line 992: lock.writeLock().unlock();
Line 993: }
Line 994: long timeEnd = System.currentTimeMillis();
Line 995: log.debugFormat("Quota Cache updated. ({0} msec)",
timeEnd-timeStart);
Please move the above log entry to info level. In normal mode it's enough to
say cache updated (and it took xxx second).
Line 996: }
Line 997:
Line 998: public boolean isCacheUpdateNeeded() {
Line 999: int quotaCount = getQuotaDAO().getQuotaCount();
--
To view, visit http://gerrit.ovirt.org/10159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
