Yair Zaslavsky has posted comments on this change.
Change subject: core: Fast init cache
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 986:
Line 987: /**
Line 988: * InitializeCache is called by SchedulerUtilQuartzImpl.
Line 989: */
Line 990: @OnTimerMethodAnnotation("initializeCache")
+1 (see also prior comment by kublin on patchset 5) - no doubt the name is
confusing.
Please rename this.
Line 991: public void initializeCache() {
Line 992: if (!isNeedToInitializeCache()) {
Line 993: return;
Line 994: }
--
To view, visit http://gerrit.ovirt.org/10159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
