Eli Mesika has posted comments on this change.

Change subject: core: Fast init cache
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File backend/manager/dbscripts/create_functions.sql
Line 608:     (quota_vds_group_id UUID, quota_id UUID,vds_group_id 
UUID,vds_group_name character,virtual_cpu INTEGER,virtual_cpu_usage 
INTEGER,mem_size_mb BIGINT,mem_size_mb_usage BIGINT);
Line 609: 
Line 610: 
Line 611: -- Summarize the VCPU usage and the RAM usage for all the VMs in the 
quota which are not down or suspended
Line 612: -- If vds group id is null, then returns the global usage of the 
quota, other wise returns only the summarize of all VMs in the specific cluster.
other wise => otherwise
summerize  => sum
Line 613: -- NOTE: VmDynamic status (0/13/14/15) must be persistent with 
UpdateVmCommand
Line 614: CREATE OR REPLACE FUNCTION CalculateAllVdsGroupUsage()
Line 615: RETURNS SETOF all_vds_group_usage_rs
Line 616: AS $function$


Line 651:         quota_limitation.quota_id as quota_id,
Line 652:         quota_limitation.storage_id as storage_id,
Line 653:         storage_domain_static.storage_name,
Line 654:         quota_limitation.storage_size_gb,
Line 655:         COALESCE(sum(size * cast(active as integer) + 
disk_image_dynamic.actual_size * cast((not active) as integer)) / (1024 * 1024 
* 1024),0) as storage_usage
more efficient to replace with the static result of that and put a comment on it
Line 656:     FROM quota_limitation
Line 657:         LEFT JOIN images ON quota_limitation.quota_id = 
images.quota_id
Line 658:         LEFT JOIN image_storage_domain_map ON images.image_guid = 
image_storage_domain_map.image_id
Line 659:         LEFT JOIN disk_image_dynamic ON images.image_guid = 
disk_image_dynamic.image_id


--
To view, visit http://gerrit.ovirt.org/10159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to