liron aravot has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * @return
Line 76: */
i'd perform the load of the connections before the call to this method and
would use this method only to return the lun type - the method name doesn't
represent that it performs dao call.
by the way, consider the location of this method..if you already wrote it,
maybe we can put it in a more general place.
Line 77: private StorageType getLunStorageType(LUNs lun) {
Line 78: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 79: .getStorageServerConnectionDao()
Line 80: .getAllForLun(lun.getLUN_id())));
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
