Maor Lipchuk has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 2: (2 inline comments)
Eduardo, I tend to guess why you don't like this fix, but for others to know
please add a comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 67: }
Line 68:
Line 69: /**
Line 70: * Return the storage type which the Lun is related to. If the LUN
has no connections we assume that it is FCP
Line 71: * storage type, since FCP does not represent connections, other
wise, we return the storage type of the first
Done
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * - The lun we set the connection at
Line 74: * @param lun
Line 75: * - The lun we set the connection at
Line 76: * @return The storage type of the lun (ISCSI or FCP)
Line 77: */
Line 78: private StorageType updateLUNConnectionsInfo(LUNs lun) {
In my opinion the comment there is good enough. if you have a better name
suggestion, I don't mind changing it.
agreed, will add a check for it (Although in this specific case Lun connection
will always not be initialized)
Line 79: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 80: .getStorageServerConnectionDao()
Line 81: .getAllForLun(lun.getLUN_id())));
Line 82: return lun.getLunConnections().isEmpty() ? StorageType.FCP :
lun.getLunConnections().get(0).getstorage_type();
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
