Alona Kaplan has posted comments on this change.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking (WIP)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
Line 106: }
Line 107:
Line 108: // Check if the given list has a VmNetworkInterface with the
Network name that is being detached.
Line 109: private VmNetworkInterface
getIfaceWithNetworkName(List<VmNetworkInterface> interfaces) {
Line 110: if (getNetworkName() == null) {
I agree with Moti. Changing the order is enough.
(getNetworkName().equals(vmNetworkInterface.getName()) instead of
vmNetworkInterface.getName().equals(getNetworkName()) ).
There is no need to check that the cluster network is not null, cause it can't
be null.
Line 111: return null;
Line 112: } else {
Line 113: return LinqUtils.firstOrNull(interfaces, new
Predicate<VmNetworkInterface>() {
Line 114: @Override
--
To view, visit http://gerrit.ovirt.org/9579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
