Moti Asayag has posted comments on this change.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking (WIP)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
Line 113: return hasDetachedNetworkName(vmNetworkInterface);
Line 114: }
Line 115: });
Line 116: }
Line 117:
you can ask here only for the network name. no need to pass the entire vNic if
not in use.
Line 118: private boolean hasDetachedNetworkName(VmNetworkInterface
vmNetworkInterface) {
Line 119: if (vmNetworkInterface.getNetworkName() != null) {
Line 120: return
vmNetworkInterface.getNetworkName().equals(getParameters().getNetwork().getname());
Line 121: } else {
--
To view, visit http://gerrit.ovirt.org/9579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
