Moti Asayag has posted comments on this change.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking (WIP)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
Line 106: }
Line 107:
Line 108: // Check if the given list has a VmNetworkInterface with the
Network name that is being detached.
Line 109: private VmNetworkInterface
getIfaceWithNetworkName(List<VmNetworkInterface> interfaces) {
Line 110: if (getNetworkName() == null) {
I don't think getNetworkName() can ever be null.
It is implemented as:
public String getNetworkName() {
return getParameters().getNetwork().getname();
}
And the Network has a validation for it minimum one character.
Line 111: return null;
Line 112: } else {
Line 113: return LinqUtils.firstOrNull(interfaces, new
Predicate<VmNetworkInterface>() {
Line 114: @Override
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1543:
Line 1544: @TypeConverterAttribute(Boolean.class)
Line 1545: @DefaultValueAttribute("true")
Line 1546: SupportForceExtendVG(398),
Line 1547:
this file is not related to this patch.
Line 1548: @TypeConverterAttribute(Boolean.class)
Line 1549: @DefaultValueAttribute("false")
Line 1550: NetworkLinkingSupported(397),
Line 1551:
--
To view, visit http://gerrit.ovirt.org/9579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
