Mike Kolesnik has posted comments on this change.
Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
Line 108:
Line 109: return true;
Line 110: }
Line 111:
Line 112: // Check if the given list has a VmNetworkInterface with the
Network name that is being detached.
Fixed to javadoc
Line 113: private VmNetworkInterface
getIfaceWithNetworkName(List<VmNetworkInterface> interfaces) {
Line 114: return LinqUtils.firstOrNull(interfaces, new
Predicate<VmNetworkInterface>() {
Line 115: @Override
Line 116: public boolean eval(VmNetworkInterface
vmNetworkInterface) {
Line 109: return true;
Line 110: }
Line 111:
Line 112: // Check if the given list has a VmNetworkInterface with the
Network name that is being detached.
Line 113: private VmNetworkInterface
getIfaceWithNetworkName(List<VmNetworkInterface> interfaces) {
Changed to boolean returning implementation (since return value unused).
Line 114: return LinqUtils.firstOrNull(interfaces, new
Predicate<VmNetworkInterface>() {
Line 115: @Override
Line 116: public boolean eval(VmNetworkInterface
vmNetworkInterface) {
Line 117: return
getNetworkName().equals(vmNetworkInterface.getName());
Line 113: private VmNetworkInterface
getIfaceWithNetworkName(List<VmNetworkInterface> interfaces) {
Line 114: return LinqUtils.firstOrNull(interfaces, new
Predicate<VmNetworkInterface>() {
Line 115: @Override
Line 116: public boolean eval(VmNetworkInterface
vmNetworkInterface) {
Line 117: return
getNetworkName().equals(vmNetworkInterface.getName());
Fixed to refer to iface network name, not name
Line 118: }
Line 119: });
Line 120: }
Line 121:
--
To view, visit http://gerrit.ovirt.org/9579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
