Gilad Chaplik has posted comments on this change.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 43: protected QuotaDAO getQuotaDAO() {
Line 44: return DbFacade.getInstance().getQuotaDao();
Line 45: }
Line 46:
Line 47: public void removeQuotasFromCache(Guid storagePoolId, List<Guid>
quotaList) {
/s/Quotas/Quota.
quota = uncountable noun.
anyhow use overloading.
Line 48: lock.writeLock().lock();
Line 49: try {
Line 50: if (!storagePoolQuotaMap.containsKey(storagePoolId)) {
Line 51: return;
Line 60: lock.writeLock().unlock();
Line 61: }
Line 62: }
Line 63:
Line 64: public void removeQuotaFromCache(Guid storagePoolId, Guid quotaId)
{
should call:
removeQuotaFromCache(storagePoolId, Arrays.toList(quotaId));
.. btw why we have here read lock and in the other method write lock?
Line 65: lock.readLock().lock();
Line 66: try {
Line 67: if (!storagePoolQuotaMap.containsKey(storagePoolId)) {
Line 68: return;
--
To view, visit http://gerrit.ovirt.org/9413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
