ofri masad has posted comments on this change.

Change subject: core: Quota Dependency Test + RemoveSnapshot fix
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaDependencyTest.java
Line 14: 
Line 15:     @Test
Line 16:     public void quotaDependencyTest() {
Line 17: 
Line 18:         for (VdcActionType vdcActionType : VdcActionType.values()) {
Done
Line 19: 
Line 20:             if (vdcActionType.getQuotaDependency() != 
VdcActionType.QuotaDependency.NONE) {
Line 21:                 Class commandClass = 
CommandsFactory.getCommandClass(vdcActionType.name());
Line 22: 


Line 59:     private boolean isImplementingRecursive(Class commandClass, Class 
interfaceClass) {
Line 60:         if 
(Arrays.asList(commandClass.getInterfaces()).contains(interfaceClass)) {
Line 61:             return true;
Line 62:         } else {
Line 63:             return commandClass.getSuperclass() != CommandBase.class
Done
Line 64:                     && 
isImplementingRecursive(commandClass.getSuperclass(), interfaceClass);
Line 65:         }
Line 66:     }


--
To view, visit http://gerrit.ovirt.org/9413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to