Allon Mureinik has posted comments on this change.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 81: storagePoolQuotaMap.remove(storagePoolId);
Line 82: } finally {
Line 83: lock.writeLock().unlock();
Line 84: }
Line 85: }
Looks like you just moved this method around - how does this relate to the
patch?
Line 86:
Line 87: private boolean
validateAndSetStorageQuotaHelper(QuotaConsumptionParametersWrapper parameters,
Line 88: Pair<AuditLogType, AuditLogableBase> auditLogPair) {
Line 89: Map<Guid, Quota> quotaMap =
storagePoolQuotaMap.get(parameters.getStoragePoolId());
--
To view, visit http://gerrit.ovirt.org/9413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
