liron aravot has posted comments on this change.
Change subject: core:WIP: introducing OvfAutoUpdate
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
Line 178: private List<Guid> getIdsToProcess(List<Guid> ids) {
Line 179: int size = (ids.size() >= ITEMS_COUNT_PER_UPDATE ?
ITEMS_COUNT_PER_UPDATE : ids.size());
Line 180: List<Guid> guidsToProcess = ids.subList(0, size);
Line 181: List<Guid> idsToProcess = new ArrayList<Guid>(guidsToProcess);
Line 182: guidsToProcess.clear();
sorry, bad wording : "what do need to be added here is creation of LinkedList
as the dao returns arraylist, will add that." - can be added here, no problem
with just nullifying the values in the arraylist.
I personally prefer it rather then handling with the indexes and it looks much
nicer.
Line 183: return idsToProcess;
Line 184: }
Line 185:
Line 186: /**
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
