Livnat Peer has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values ......................................................................
Patch Set 2: Hi Ravi, Generally nice cleanup, I have noticed that the following config keys have the same value for all versions (after you remove the 2.2 key): DesktopAudioDeviceType MaxNumOfCpuPerSocket MaxNumOfVmSockets MaxNumOfVmCpus PredefinedVMProperties VdsFenceType VM64BitMaxMemorySizeInMB Is there a reason to keep them? and if so do we want to keep them per version instead of a single general config? I saw you cleaned other keys so maybe there is a reason you chose to leave these specifically. -- To view, visit http://gerrit.ovirt.org/9131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
