Liron Aravot has posted comments on this change. Change subject: core: compensation should not clean entities with associated tasks ......................................................................
Patch Set 3: Yair, concrete flow: current flow: AddVmFromTemplateCommand 1. we create tasks for 1 disk out of 5 which start executes on vdsm 2. engine crashes and starts up 3. compensation is being cleared 4. tasks ends on vdsm 5. endSuccesfully is being called 6. reloadVmTemplateFromDB returns null (cleared by compensation). 7. we don't perform any template related ops and end the flow, template doesn't exist partially. flow after this patch - 1 - 2 : same 3. compensation for this command isn't executed as we have tasks on vdsm 4-5. the same 6. reloadVmTemplateFromDB returns the template (wasn't cleared by compensation) 7. endActions on the template are being executed - we will see the template under 'templates' although it contains only part of the disks. when the missing tasks issue will be resolved, we won't have that issue. -- To view, visit http://gerrit.ovirt.org/9122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
