Liron Aravot has posted comments on this change. Change subject: core: compensation should not clean entities with associated tasks ......................................................................
Patch Set 3: I would prefer that you didn't submit this I think that this change should be merge only after all other tasks related patch will be merged (missing tasks). right now this change will cause problem in most parent-children commands, right now the fact that compensation runs is being used as a safety measurement in endSuccesfully() method, most commands check in endSuccesfuly() if entities that they added still exist, if they aren't they assume that compensation has ran and doesn't perform any operations. not performing the compensation will hurt all of those flows as they will run endSuccesfully although there might have been missing tasks, so the user will have inconsistent data. -- To view, visit http://gerrit.ovirt.org/9122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
