Liron Aravot has posted comments on this change. Change subject: core: compensation should not clean entities with associated tasks ......................................................................
Patch Set 3: Yair, as you know - right now we have the missing tasks issue. With current task handling (insertion to async tasks table as we create a task) .right now the fact that compensation runs on server startup for all commands is being used as a safety measurement in endSuccesfully() method, most commands check in endSuccesfuly() if entities that they added and created compensation snapshot for still exist, if they aren't they assume that compensation has ran after server crash and perform accordingly in the endSucessfuly method. not performing the compensation for those commands will hurt all of those flows as they will run endSuccesfully after compensation hasn't ran although there might have been missing tasks. -- To view, visit http://gerrit.ovirt.org/9122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
