Hunt Xu has posted comments on this change.
Change subject: packaging: allow specifying MAC range during setup
......................................................................
Patch Set 2: No score
(2 inline comments)
Thanks Moti and Simon.
Agree with the idea of keeping it simple, making it use the default value
unless a command line argument is explicitly specified.
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-19 14:47:54 +0800
Line 4: Commit: huntxu <mhun...@gmail.com>
Line 5: CommitDate: 2012-10-19 15:13:40 +0800
Line 6:
Line 7: packaging: allow specifying MAC range during setup
will do
Line 8:
Line 9: By default the setup script automatically generates a MAC range
Line 10: for the MAC pool which contains 256 MAC addresses. However it is
Line 11: not enough for a larger scale. Therefore it's better to make the
....................................................
File packaging/fedora/setup/engine-setup.py
Line 254: "NEED_CONFIRM" : False,
Line 255: "CONDITION" : False}]
Line 256: ,
Line 257: "ALL_PARAMS" : [
Line 258: { "CMD_OPTION" :"mac-range",
Conforming to the CONF_NAME in the database, I'd prefer make no changes to the
naming behavior of the codes. However, correction of the output messages should
be done. How about splitting the messages correction to another patch?
Line 259: "USAGE"
:output_messages.INFO_CONF_PARAMS_MAC_RANGE_USAGE,
Line 260: "PROMPT"
:output_messages.INFO_CONF_PARAMS_MAC_RANGE_PROMPT,
Line 261: "OPTION_LIST" :[],
Line 262: "VALIDATION_FUNC" :validate.validateMacRange,
--
To view, visit http://gerrit.ovirt.org/8670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie39a44af437afb9f752be1f824d964a7d52fb5ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhun...@gmail.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Simon Grinberg <sgrin...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
