Moti Asayag has posted comments on this change. Change subject: packaging: allow specifying MAC range during setup ......................................................................
Patch Set 2: On one hand, the patch provides the functionality to override the auto-range of MAC addresses. On the other one hand,it extends the length and the amount of required properties of the setup process. This property isn't mandatory for the installation itself (using the default will serve good untill all of the addresses are consumed and then the engine-config tool could be in use). However, for predefined large scale setup this patch makes absolutely sense. Therefore I'd suggest to add this parameter (and perhaps other known-non-mandatory and not commonly configured) to an 'Advanced Section' in the setup process in which those parameters could be set, and to maintain the common setup process short. Ofer, Moran, what do you think ? -- To view, visit http://gerrit.ovirt.org/8670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie39a44af437afb9f752be1f824d964a7d52fb5ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
