Simon Grinberg has posted comments on this change. Change subject: packaging: allow specifying MAC range during setup ......................................................................
Patch Set 2: I would prefer that you didn't submit this I think we should keep it simple meaning decide which are our bare minimum and force them as interactive if not provided in the config/command line. The rest are command line/config options only to the installer, you don't have to walk the user through all of them but the user may provide during setup. So for MACs I will only add a --mac-range option to the setup and that's it. If not given use default. I don't see a reason to bother every user with providing MAC range. We need to think on cumulative effect, when more and more config parameters will be added making the installation process tedious. -- To view, visit http://gerrit.ovirt.org/8670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie39a44af437afb9f752be1f824d964a7d52fb5ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Simon Grinberg <sgrin...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
