Moti Asayag has posted comments on this change.
Change subject: packaging: allow specifying MAC range during setup
......................................................................
Patch Set 2: Verified
(3 inline comments)
After building with this patch I was able to override the predefined range
(00:1A:4A:23:01:00-00:1A:4A:23:01:FF) with the values below. If range is not
provided, the default is taken.
engine=# select * from vdc_options where option_name = 'MacPoolRanges';
option_id | option_name | option_value | version
-----------+---------------+-------------------------------------+---------
156 | MacPoolRanges | 00:1A:4A:23:01:BB-00:1A:4A:23:01:EE | general
Validations of the MAC addresses range was also verified.
There are few text comments.
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-19 14:47:54 +0800
Line 4: Commit: huntxu <mhun...@gmail.com>
Line 5: CommitDate: 2012-10-19 15:13:40 +0800
Line 6:
Line 7: packaging: allow specifying MAC range during setup
s/MAC/MAC addresses/g
Line 8:
Line 9: By default the setup script automatically generates a MAC range
Line 10: for the MAC pool which contains 256 MAC addresses. However it is
Line 11: not enough for a larger scale. Therefore it's better to make the
....................................................
File packaging/fedora/setup/engine-setup.py
Line 254: "NEED_CONFIRM" : False,
Line 255: "CONDITION" : False}]
Line 256: ,
Line 257: "ALL_PARAMS" : [
Line 258: { "CMD_OPTION" :"mac-range",
s/mac-range/mac-addresses-range
Line 259: "USAGE"
:output_messages.INFO_CONF_PARAMS_MAC_RANGE_USAGE,
Line 260: "PROMPT"
:output_messages.INFO_CONF_PARAMS_MAC_RANGE_PROMPT,
Line 261: "OPTION_LIST" :[],
Line 262: "VALIDATION_FUNC" :validate.validateMacRange,
....................................................
File packaging/fedora/setup/output_messages.py
Line 162: INFO_VAL_PORT_NOT_RANGE="Error: port is outside the range of %i -
65535"
Line 163: INFO_VAL_CHOOSE_PORT = "Please choose a different port."
Line 164: INFO_VAL_FAILED_ADD_PORT_TO_HTTP_POLICY="Error: failed adding port %d
to " + basedefs.HTTP_PORT_POLICY + " because it is \
Line 165: already preallocated in selinux."
Line 166: INFO_VAL_MAC_RANGE_INVALID="Invalid MAC range for the virtual
machines"
please add 'addresses' after the MAC.
Line 167: INFO_VAL_STRING_EMPTY="Error: can't accept an empty answer for param"
Line 168: INFO_VAL_NOT_IN_OPTIONS="Error: response is not part of the following
accepted answers: %s"
Line 169: INFO_VAL_NOT_DOMAIN="Error: domain is not a valid domain name"
Line 170: INFO_VAL_NOT_USER="Error: user name contains illegal characters"
--
To view, visit http://gerrit.ovirt.org/8670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie39a44af437afb9f752be1f824d964a7d52fb5ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhun...@gmail.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
