anmolbabu has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/39945/23/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 437: Line 438: AsyncDataProvider.getInstance().getIsGlusterVolumeSnapshotCliScheduleEnabled(new AsyncQuery(this, new INewAsyncCallback() { Line 439: @Override Line 440: public void onSuccess(Object model, Object returnValue) { Line 441: Boolean isCliScheduleEnabled = (Boolean) returnValue; the dialog is not blocked from user action here, so its possible that the result of query in here remains unnoticed by the user. Line 442: snapshotModel.getDisableCliSchedule().setEntity(isCliScheduleEnabled); Line 443: } Line 444: }), volumeEntity.getClusterId()); Line 445: https://gerrit.ovirt.org/#/c/39945/23/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java: Line 306: } Line 307: Line 308: public void setDisableCliSchedule(EntityModel<Boolean> value) { Line 309: this.disableCliSchedule = value; Line 310: this.disableCliSchedule.setIsAvailable(value.getEntity()); when would this be of use except for in init which is always false. I mean in line 442 of GlusterVolumeSnapshotListModel you are doing snapshotModel#getDisableCliSchedule#setEntity but that doesn't come here right? Line 311: } Line 312: Line 313: public boolean validate(boolean inplaceValidate) { Line 314: String propName; https://gerrit.ovirt.org/#/c/39945/23/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml: Line 122: </t:tab> Line 123: </t:DialogTabPanel> Line 124: </d:content> Line 125: </d:SimpleDialogPanel> Line 126: </ui:UiBinder> trailing space? -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
