Eli Mesika has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/39945/23/packaging/dbscripts/upgrade/03_06_1580_add_gluster_cli_based_snapshot_scheduled_column_to_vds_groups.sql File packaging/dbscripts/upgrade/03_06_1580_add_gluster_cli_based_snapshot_scheduled_column_to_vds_groups.sql: Line 1: select fn_db_add_column('vds_groups', 'gluster_cli_based_snapshot_scheduled', 'BOOLEAN NOT NULL DEFAULT TRUE'); Can't we achieve that via the supported_cluster_features table ? https://gerrit.ovirt.org/#/c/39945/23/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 116: max_vds_memory_over_commit = v_max_vds_memory_over_commit, Line 117: count_threads_as_cores = v_count_threads_as_cores, Line 118: compatibility_version = v_compatibility_version,transparent_hugepages = v_transparent_hugepages, Line 119: migrate_on_error = v_migrate_on_error, Line 120: virt_service = v_virt_service, gluster_service = v_gluster_service, gluster_cli_based_snapshot_scheduled = v_gluster_cli_based_snapshot_scheduled, tunnel_migration = v_tunnel_migration, please try to keep only one column update in a line, if there are more it makes it hard to see the diff when something changed Line 121: emulated_machine = v_emulated_machine, detect_emulated_machine = v_detect_emulated_machine, trusted_service = v_trusted_service, ha_reservation = v_ha_reservation , optional_reason = v_optional_reason, maintenance_reason_required = v_maintenance_reason_required, cluster_policy_id = v_cluster_policy_id, Line 122: cluster_policy_custom_properties = v_cluster_policy_custom_properties, enable_balloon = v_enable_balloon, architecture = v_architecture, Line 123: optimization_type = v_optimization_type, spice_proxy = v_spice_proxy, enable_ksm = v_enable_ksm, Line 124: serial_number_policy = v_serial_number_policy, custom_serial_number = v_custom_serial_number, -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
