Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/39945/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 71: isGlusterCliBasedSchedulingOn > optional: s/isGlusterCliBasedSchedulingOn/glusterCliBasedSchedulingOn Done Line 256: public boolean supportsGlusterService() { Line 257: return glusterService; Line 258: } Line 259: Line 260: public void setIsGlusterCliBasedSchedulingOn(boolean isGlusterCliBasedSchedulingOn) { > boolean setter should be named: setGlusterCliBasedSchedulingOn Done Line 261: this.isGlusterCliBasedSchedulingOn = isGlusterCliBasedSchedulingOn; Line 262: } Line 263: Line 264: public boolean isGlusterCliBasedSchedulingOn() { -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
