Moti Asayag has posted comments on this change. Change subject: engine: Validate on network remove/modify ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41538/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 717: } Line 718: VdsNetworkInterface existingIface = getExistingIfaceByNetwork(iface.getNetworkName()); Line 719: if (existingIface != null) { Line 720: String oldAddress = existingIface.getAddress(); Line 721: return !StringUtils.isEmpty(oldAddress) && !StringUtils.equals(oldAddress, iface.getAddress()); please use StringUtils.isNotEmpty Line 722: } Line 723: } Line 724: return false; Line 725: } -- To view, visit https://gerrit.ovirt.org/41538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
