Sahina Bose has posted comments on this change. Change subject: engine: Validate on network remove/modify ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41538/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 171: removedNetwork.getCluster() == null > removedNetwork.getCluster() == null shouldn't ever occur. Done Line 718: } Line 719: VdsNetworkInterface existingIface = getExistingIfaceByNetwork(iface.getNetworkName()); Line 720: if (existingIface != null) { Line 721: String oldAddress = existingIface.getAddress(); Line 722: return !StringUtils.equals(oldAddress, iface.getAddress()); > just to make sure - is it mandatory for gluster network to have ip address This validation is done only when a brick is using the network, and the brick would only use the network when an ip address is available. So I think we are ok with that use case. Line 723: } Line 724: } Line 725: return false; Line 726: } -- To view, visit https://gerrit.ovirt.org/41538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
