Moti Asayag has posted comments on this change. Change subject: engine: Validate on network remove/modify ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41538/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 718: } Line 719: VdsNetworkInterface existingIface = getExistingIfaceByNetwork(iface.getNetworkName()); Line 720: if (existingIface != null) { Line 721: String oldAddress = existingIface.getAddress(); Line 722: return !StringUtils.equals(oldAddress, iface.getAddress()); > This validation is done only when a brick is using the network, and the bri what if the interface loose its ip address and vdsm doesn't report it, and the user would like to configure a different ip address for it ? Imagine the following scenario: 1. Admin configure dhcp boot protocol for 'red'network 2. 'red' network gets an ip address, vdsm reports it and it save to the engine-db. 3. bricks are using that network 4. some dhcp error/host error causes the 'red' network to loose its ip. 5. vdsm reports it and the 'no-ip' is saved to the db now the admin wishes to manually configure a static ip address for that nic: 1. condition criteria on line 712 is met 2. condition criteria on line 70 is met 3. condition criteria on line 722 aren't met, although the admin should have been able to configure the ip address. Does this make sense as a valid scenario ? else we can ignore this comment the continue with the patch as is. Line 723: } Line 724: } Line 725: return false; Line 726: } -- To view, visit https://gerrit.ovirt.org/41538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
