Moti Asayag has posted comments on this change. Change subject: engine: Validate on network remove/modify ......................................................................
Patch Set 1: (2 comments) Martin, please note this logic should also be covered by the new api. https://gerrit.ovirt.org/#/c/41538/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 171: removedNetwork.getCluster() == null removedNetwork.getCluster() == null shouldn't ever occur. Line 718: } Line 719: VdsNetworkInterface existingIface = getExistingIfaceByNetwork(iface.getNetworkName()); Line 720: if (existingIface != null) { Line 721: String oldAddress = existingIface.getAddress(); Line 722: return !StringUtils.equals(oldAddress, iface.getAddress()); just to make sure - is it mandatory for gluster network to have ip address ? Else, if the user attaches a network in one action without an address, and in a following action the user tries to set an address for it, it will be blocked by this method. Perhaps you should permit the user to add an address if there isn't any ? Line 723: } Line 724: } Line 725: return false; Line 726: } -- To view, visit https://gerrit.ovirt.org/41538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
