Michael Kublin has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED ......................................................................
Patch Set 9: I would prefer that you didn't submit this Code can not lie .My opinion you don't know what you are trying to solve and how. Now, about writing a wrong commit message and providing a half patch, I don't understand the idea of that, it is some kind of training guide for reviewer, to find all bugs and problems with out running a code? The status Locked forever can be caused because of using compensation in ActivatestorageDomainCommand, so now please write a correct patch. Also you are patch creating unneeded races during AddStoragePoolWithStorages. -- To view, visit http://gerrit.ovirt.org/8536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8b9fc0d324eac2146d4f7d60d48e4dd5eb5d9e0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
