Allon Mureinik has posted comments on this change.
Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay
LOCKED
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
Line 122: getStoragePoolIsoMapDAO()
Line 123: .updateStatus(
Line 124: new StoragePoolIsoMapId(storageDomainId,
getStoragePool().getId()),
Line 125: StorageDomainStatus.InActive);
Line 126: }
I'd have the for-loop in a transaction
Line 127: // Create pool phase completed, no rollback is needed here,
so compensation information needs to be cleared!
Line 128: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 129: @Override
Line 130: public Void runInTransaction() {
Line 228: getStoragePool().getId());
Line 229:
activateParameters.setSessionId(getParameters().getSessionId());
Line 230:
activateParameters.setTransactionScopeOption(TransactionScopeOption.RequiresNew);
Line 231: Backend.getInstance()
Line 232:
.runInternalAction(VdcActionType.ActivateStorageDomain,
activateParameters).getSucceeded();
Once we succeed in activating the domain in VDSM, shouldn't we flag it as so in
the DB?
Line 233:
Line 234: }
Line 235: }
Line 236:
--
To view, visit http://gerrit.ovirt.org/8536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8b9fc0d324eac2146d4f7d60d48e4dd5eb5d9e0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
