Moti Asayag has posted comments on this change.

Change subject: vdsbroker: async vdscommand
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/40565/10/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java:

Line 49: 
Line 50:     @Override
Line 51:     protected void executeCommand() {
Line 52:         try {
Line 53:             // creating ReturnValue object since execute can be called 
more than once (failover)
please move the comment to the right place as well :) (line 59)
Line 54:             // and we want returnValue clean from last run.
Line 55:             if (isAsync()) {
Line 56:                 executeCommandAsynchronously();
Line 57:                 return;


-- 
To view, visit https://gerrit.ovirt.org/40565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to