Moti Asayag has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/40565/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java: Line 53: // creating ReturnValue object since execute can be called more than once (failover) Line 54: // and we want returnValue clean from last run. Line 55: _returnValue = new VDSReturnValue(); Line 56: getVDSReturnValue().setSucceeded(true); Line 57: if (isAsync()) { since VDSAsyncReturnValue will be returned in case of async execution, the 2 lines above can be moved prior to the sync execution, after the if block, or to instantiate its async impl. Line 58: executeCommandAsynchronously(); Line 59: return; Line 60: } Line 61: executeVDSCommand(); -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
