Oved Ourfali has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/40565/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java: Line 55: _returnValue = new VDSReturnValue(); Line 56: getVDSReturnValue().setSucceeded(true); Line 57: if (isAsync()) { Line 58: executeCommandAsynchronously(); Line 59: return; > i'd remove the return and add an else block for executeVDSCommand() Not critical. Up to you, Piotr. Line 60: } Line 61: executeVDSCommand(); Line 62: } catch (RuntimeException ex) { Line 63: setVdsRuntimeError(ex); https://gerrit.ovirt.org/#/c/40565/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 69: @Override Line 70: public Object process(Object returnValue, VDSAsyncReturnValue value) { Line 71: DiskImage di = null; Line 72: try { Line 73: proceedProxyReturnValue(); > proceedProxyReturnValue() throws exceptions that are handled higher in the We plan to remove this file from this patch, and post it in the sample file. Then, you'll be able to choose whether to use the sample implementation, or change it as you see fit. Line 74: di = buildImageEntity((Map<String, Object>) returnValue); Line 75: } catch (Exception e) { Line 76: printReturnValue(); Line 77: } finally { -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
