Alon Bar-Lev has posted comments on this change.

Change subject: uutils: added new cli parser
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/40157/11/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java
File 
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java:

Line 156: 
Line 157:     /**
Line 158:      * Map of correctly parsed and converted arguments
Line 159:      */
Line 160:     private Map<String, Object> argMap = new HashMap<>();
parsedArgs?
Line 161: 
Line 162:     /**
Line 163:      * List of errors which was found during pasring
Line 164:      */


Line 193:      *
Line 194:      * @param args list of command line arguments
Line 195:      * @return true if parsing has no errors, false otherwise
Line 196:      */
Line 197:     public boolean parse(List<String> args) {
must clear errors and argMap to start a new clean sequence.
Line 198:         while(!args.isEmpty()) {
Line 199:             String arg = args.get(0);
Line 200:             if(!arg.startsWith(LONG_PREFIX)) {
Line 201:                 break;


-- 
To view, visit https://gerrit.ovirt.org/40157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com>
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to