mooli tayer has posted comments on this change.

Change subject: uutils: added new cli parser
......................................................................


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/40157/10/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java
File 
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java:

Line 74:  * """
Line 75:  * </p>
Line 76:  *
Line 77:  * Example:
Line 78:  *  We have program which support two actions - [add, remove]. Both 
actions accepts different arguments and program too.
s/program/a program/
s/Both actions accepts/Both actions accept

also I don't understand the "and program too" part.
Line 79:  *   ./out [--file] add --message=X [--index]
Line 80:  *   ./out [--file] remove [--index]
Line 81:  *
Line 82:  *  The properties file of this program can look like:


Line 80:  *   ./out [--file] remove [--index]
Line 81:  *
Line 82:  *  The properties file of this program can look like:
Line 83:  *   module.arg.file.name = file
Line 84:  *   module.arg.file.help = File where store message
s/File where store message/file where messages are stored/
Line 85:  *   module.arg.file.default = /tmp/X
Line 86:  *   add.arg.message.name = message
Line 87:  *   add.arg.message.help = Message to be stored
Line 88:  *   add.arg.message.mandatory = true


Line 90:  *   add.arg.index.name = index
Line 91:  *   add.arg.index.help = Index where message should be inserted
Line 92:  *   add.arg.index.value = 0
Line 93:  *   add.arg.index.default = 0
Line 94:  *   add.arg.index.type = OPTIONAL
sorry I still don't get it...

"if argument is mandatory and if argument is not specified on command line then 
set value which is stored in arg.default"

this means afaiu that 'default' has no meaning if arg is not mandatory. (which 
I also don't understand why)
Line 95:  *   remove.arg.index.name = index
Line 96:  *   remove.arg.index.help = Index where message should be inserted
Line 97:  *   remove.arg.index.value = 0
Line 98:  *   remove.arg.index.default = 0


-- 
To view, visit https://gerrit.ovirt.org/40157
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com>
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to