Martin Peřina has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/40157/8/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 162: private void putValue(Map<String, Object> argMap, ParserArgument arg, Object value) { Line 163: if (!arg.isMultivalue()) { Line 164: argMap.put(arg.getName(), value); Line 165: } else { Line 166: Collection c = (Collection) argMap.get(arg.getName()); > Done There's no sense to use Collection when you insert ArrayList instance as a value Line 167: if (c == null) { Line 168: c = new ArrayList<>(); Line 169: argMap.put(arg.getName(), c); Line 170: } https://gerrit.ovirt.org/#/c/40157/8/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParserArgument.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParserArgument.java: Line 105: if(obj == this) { Line 106: return true; Line 107: } Line 108: Line 109: return this.name.equals(((ParserArgument) obj).getName()); > I am not sure what the difference is... martin, can you please explain? You should check for nullability to prevent NPE if you use name.equals(other.name); Objects.equals already contains this test, so it can be used in all cases. Line 110: } Line 111: Line 112: @Override Line 113: public int hashCode() { -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
