mooli tayer has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/40157/10/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java: Line 273: ) Line 274: ); Line 275: } Line 276: others.addAll(args); Line 277: argMap.put(PARAMETER_KEY_POSITIONAL, others); you can remove the two lines above as well as List<Object> others = new ArrayList<>(); and instead do: argMap.put(PARAMETER_KEY_POSITIONAL, args); AFAIK this is what Alon's comment on line 187 means Line 278: argMap.put(PARAMETER_KEY_ERRORS, errors); Line 279: Line 280: return argMap; Line 281: } -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
