ofri masad has posted comments on this change.

Change subject: core : QuotaMnager Test - basic structure
......................................................................


Patch Set 7: (5 inline comments)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
Line 73: 
Line 74:     private QuotaManager quotaManager = 
Mockito.spy(QuotaManager.getInstance());
Line 75:     private storage_pool storage_pool = new storage_pool();
Line 76:     private static ArrayList<String> canDoActionMessages = new 
ArrayList<String>();
Line 77:     private static boolean hardEnforcement = true;
Done
Line 78:     private static boolean auditLogWritten = false;
Line 79:     private static boolean dbWasCalled = false;
Line 80: 
Line 81:     @Before


Line 74:     private QuotaManager quotaManager = 
Mockito.spy(QuotaManager.getInstance());
Line 75:     private storage_pool storage_pool = new storage_pool();
Line 76:     private static ArrayList<String> canDoActionMessages = new 
ArrayList<String>();
Line 77:     private static boolean hardEnforcement = true;
Line 78:     private static boolean auditLogWritten = false;
Done
Line 79:     private static boolean dbWasCalled = false;
Line 80: 
Line 81:     @Before
Line 82:     public void testSetup() {


Line 75:     private storage_pool storage_pool = new storage_pool();
Line 76:     private static ArrayList<String> canDoActionMessages = new 
ArrayList<String>();
Line 77:     private static boolean hardEnforcement = true;
Line 78:     private static boolean auditLogWritten = false;
Line 79:     private static boolean dbWasCalled = false;
Done
Line 80: 
Line 81:     @Before
Line 82:     public void testSetup() {
Line 83:         mockQuotaDAO();


Line 130:         storage_pool.setId(new 
Guid("00000000-0000-0000-0000-000000001111"));
Line 131:     }
Line 132: 
Line 133:     private static void assertNotEmptyCanDoActionMessage() {
Line 134:         assertTrue(EXPECTED_CAN_DO_MESSAGE, 
canDoActionMessages.size() > 0);
Done
Line 135:         canDoActionMessages.clear();
Line 136:     }
Line 137: 
Line 138:     private static void assertEmptyCanDoActionMessage() {


Line 135:         canDoActionMessages.clear();
Line 136:     }
Line 137: 
Line 138:     private static void assertEmptyCanDoActionMessage() {
Line 139:         assertTrue(EXPECTED_EMPTY_CAN_DO_MESSAGE, 
canDoActionMessages.size() == 0);
Done
Line 140:     }
Line 141: 
Line 142:     private static void assertAuditLogWritten() {
Line 143:         assertTrue(EXPECTED_AUDIT_LOG_MESSAGE, auditLogWritten);


--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to