Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
minor issue inline, please fix when you rebase and merge
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
Line 23:
Line 24: import static org.junit.Assert.assertTrue;
Line 25: import static org.junit.Assert.assertFalse;
Line 26: import static org.mockito.Matchers.any;
Line 27: import static org.mockito.Mockito.*;
why do you keep reverting to * imports?
Please use FQCNs.
Line 28:
Line 29: @RunWith(MockitoJUnitRunner.class)
Line 30: public class QuotaManagerTest {
Line 31:
--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
