Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 18: (1 inline comment)
Answered Allon's question in-line.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java
Line 58: import org.ovirt.engine.core.utils.ejb.ContainerManagedResourceType;
Line 59: import org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy;
Line 60: import org.ovirt.engine.core.utils.ejb.EjbUtils;
Line 61:
Line 62: public class GlusterManagerTest extends BaseDAOTestCase {
Yes, I've added that dependency (only for this one test class). GlusterManager
syncs the gluster related data in the engine DB with data fetched from
glusterfs. To test this, I need existing gluster related data in the database,
and test various scenarios by mocking data received from glusterfs. I thought
it would be best to reuse the data from test database for this purpose. Let me
know if you have a problem with this, and any better approach.
Line 63:
Line 64: @Mock
Line 65: private EJBUtilsStrategy mockLookupStrategy;
Line 66:
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
