Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 468: private void createVolume(final GlusterVolumeEntity volume) {
Line 469: if (volume.getBricks() == null) {
Line 470: log.warnFormat("Bricks of volume {0} were not fetched. " +
Line 471: "Hence will not add it to engine at this point.",
volume.getName());
Line 472: return;
Besides a warning in the log - don't you want to throw an exception here?
Line 473: }
Line 474:
Line 475: for (GlusterBrickEntity brick : volume.getBricks()) {
Line 476: if (brick.getServerId() == null) {
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
