Yair Zaslavsky has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 13: No score
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 174:
Line 175: private void removeDetachedServers(List<VDS> existingServers,
Set<GlusterServerInfo> fetchedServers) {
Line 176: for (VDS server : existingServers) {
Line 177: if (isRemovableStatus(server.getstatus()) &&
serverDetached(server, fetchedServers)) {
Line 178: RemoveVdsStatisticsFromDb(server);
Shouldn't these 3 removeXXX be in the same transaction?
Line 179: RemoveVdsDynamicFromDb(server);
Line 180: RemoveVdsStaticFromDb(server);
Line 181:
Line 182: // remove the server from resource manager
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
