Juan Hernandez has posted comments on this change. Change subject: restapi: add field ksm_merge_across_node to cluster ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39783/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1865: Line 1866: <xs:complexType name="KSM"> Line 1867: <xs:sequence> Line 1868: <xs:element name="enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1869: <xs:element ref="merge_across_nodes" minOccurs="0" maxOccurs="1"/> My understanding is that "merge_across_nodes" is just a boolean, so the top level element definition and complex type aren't needed, only a plain xs.boolean: <xs:complexType name="KSM"> <xs:element name="enabled" type="xs:boolean" .../> <xs:element name="merge_across_nodes" type="xs:boolean".../> </xs:complexType> Line 1870: </xs:sequence> Line 1871: </xs:complexType> Line 1872: Line 1873: <xs:element name="transparent_hugepages" type="TransparentHugePages"/> -- To view, visit https://gerrit.ovirt.org/39783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd6ce2c42b4d7fa30088c77d5f16d0dfdabb156a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
