Dudi Maroshi has posted comments on this change. Change subject: restapi: add field ksm_merge_across_node to cluster ......................................................................
Patch Set 2: In response to this comment from Juan --------------------------- The RESTAPI doesn't need to reflect the database structure, specially if the database structure doesn't reflect reality. Reality is that "ksm.enabled" and "ksm.merge_across_nodes" are two properties of the same "ksm" concept, so they belong in the same element inside the RESTAPI. Grouping together related properties simplifies things, specially for users. If you are an user where do you expect to see KSM properties? Directly in a cluster or inside a "KSM" object? If this is a hidden feature then it shouldn't be part of the RESTAPI. All in all, please move the new property to the existing "ksm" object or, if this is really hidden, abandon this patch. -------------------------- Very valid arguments. The suggestion will be implemented in next patch set 3. -- To view, visit https://gerrit.ovirt.org/39783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd6ce2c42b4d7fa30088c77d5f16d0dfdabb156a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
