Juan Hernandez has posted comments on this change. Change subject: restapi: add field ksm_merge_across_node to cluster ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39783/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1859: <xs:complexType name="KSMMergeAcrossNodes"> Line 1860: <xs:sequence> Line 1861: <xs:element name="enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1862: </xs:sequence> Line 1863: </xs:complexType> > The cluster already has a "ksm" element, so I think it is better to add thi Sorry, I just see that the name used in the kernel is "merge_across_nodes", as you proposed, so it is ok to use it. Line 1864: Line 1865: <xs:element name="ksm" type="KSM"/> Line 1866: Line 1867: <xs:complexType name="KSM"> -- To view, visit https://gerrit.ovirt.org/39783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd6ce2c42b4d7fa30088c77d5f16d0dfdabb156a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
