[Engine-patches] Change in ovirt-engine[master]: restapi: add field ksm_merge_across_node to cluster

[juan . hernandez]

Juan Hernandez has posted comments on this change.

Change subject: restapi: add field ksm_merge_across_node to cluster
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/39783/5/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java:

Line 101:         }
Line 102:         if (model.isSetBallooningEnabled()) {
Line 103:             entity.setEnableBallooning(model.isBallooningEnabled());
Line 104:         }
Line 105:         if (model.isSetKsm() == true) {
The "== true" is redundant, but the check for "isSetEnabled" is not. There may 
be situations where the user sends an empty "ksm" element, for example:

  <cluster>
    <ksm/>
  </cluster>

This is meaningless, but possible, and in that case this code will generate 
NPEs. Before accessing an element provided by the user you always need to check 
if it has actually been provided, for example:

  if (model.isSetKsm()) {
    if (model.getKsm().isSetEnabled()) {
      entity.setEnableKsm(model.getKsm().isEnabled());
    }
    if (model.getKsm().isSetMergeAcrossNodes()) {
      entity.setKsmMergeAcrossNumaNodes(model.getKsm().isMergeAcrossNodes()=;
    }
  }
Line 106:             entity.setEnableKsm(model.getKsm().isEnabled());
Line 107:             
entity.setKsmMergeAcrossNumaNodes(model.getKsm().isMergeAcrossNodes());
Line 108:         }
Line 109:         if (model.isSetDisplay() && model.getDisplay().isSetProxy()) {


-- 
To view, visit https://gerrit.ovirt.org/39783
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd6ce2c42b4d7fa30088c77d5f16d0dfdabb156a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <d...@redhat.com>
Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches