Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 106: protected void validateFingerprint(SSHClient client, String
fingerprint) {
Line 107: if (!fingerprint.equals(getFingerprint(client))) {
Line 108: throw new AccessControlException(String.format("SSH
Fingerprint of server "
Line 109: + getParameters().getServerName()
Line 110: + " did not match expected fingerprint " +
fingerprint));
This is not how you use string.format.
Should be:
throw new AccessControlException(
String.format(
"SSH Fingerprint of server '%1$s' did not match expected fingerprint
'%2$s'",
getParameters().getServerName(),
fingerprint
)
);
Now I also notice that we still have getParameters() not in topmost query
function.... I need to add getHost(), getPort() at SSHClient.java.
Will do this shortly.
Line 111: }
Line 112: }
Line 113:
Line 114: // This is required for mock during Junit test
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
